linux-kernel - Re: [PATCH] arm64: dts: qcom: qcs404: Fix sdhci compat string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200127170457.GK2841@vkoul-mobl>
Date:   Mon, 27 Jan 2020 22:34:57 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Douglas Anderson <dianders@...omium.org>
Cc:     Bjorn Andersson <bjorn.andersson@...aro.org>,
        Andy Gross <andy.gross@...aro.org>, mka@...omium.org,
        vbadigan@...eaurora.org, devicetree@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>
Subject: Re: [PATCH] arm64: dts: qcom: qcs404: Fix sdhci compat string

On 27-01-20, 08:23, Douglas Anderson wrote:
> As per the bindings, the SDHCI controller should have a SoC-specific
> compatible string in addition to the generic version-based one.  Add
> it.

Thanks for spotting it Doug, Btw did some script catch it or manual
inspection?


Reviewed-by: Vinod Koul <vkoul@...nel.org>

> Fixes: 7241ab944da3 ("arm64: dts: qcom: qcs404: Add sdcc1 node")
> Signed-off-by: Douglas Anderson <dianders@...omium.org>
> ---
> 
>  arch/arm64/boot/dts/qcom/qcs404.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/qcs404.dtsi b/arch/arm64/boot/dts/qcom/qcs404.dtsi
> index 4ee1e3d5f123..1eea06435779 100644
> --- a/arch/arm64/boot/dts/qcom/qcs404.dtsi
> +++ b/arch/arm64/boot/dts/qcom/qcs404.dtsi
> @@ -685,7 +685,7 @@ pcie_phy: phy@...6000 {
>  		};
>  
>  		sdcc1: sdcc@...4000 {
> -			compatible = "qcom,sdhci-msm-v5";
> +			compatible = "qcom,qcs404-sdhci", "qcom,sdhci-msm-v5";
>  			reg = <0x07804000 0x1000>, <0x7805000 0x1000>;
>  			reg-names = "hc_mem", "cmdq_mem";
>  
> -- 
> 2.25.0.341.g760bfbb309-goog

-- 
~Vinod