linux-kernel - Re: [PATCH V2] drm/v3d: remove duplicated kfree in v3d_submit_cl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <56e99398-15be-aeb0-32b3-aa8a20d71e97@web.de>
Date:   Mon, 27 Jan 2020 08:20:48 +0100
From:   Markus Elfring <Markus.Elfring@....de>
To:     Yu Kuai <yukuai3@...wei.com>,
        Daniel Vetter <daniel.vetter@...ll.ch>,
        Eric Anholt <eric@...olt.net>,
        Navid Emamdoost <navid.emamdoost@...il.com>,
        dri-devel@...ts.freedesktop.org
Cc:     linux-kernel@...r.kernel.org, David Airlie <airlied@...ux.ie>,
        Yi Zhang <yi.zhang@...wei.com>,
        zhengbin <zhengbin13@...wei.com>
Subject: Re: [PATCH V2] drm/v3d: remove duplicated kfree in
 v3d_submit_cl_ioctl

> kfree() was called for the same variable twice within an if branch.

I wonder still how this software situation happened.

Now I imagine that it could be more logical to delete the second of
this function call if you would like to look at the history of previous
two patches once more.

How do you think about to add another jump target for a bit of common
exception handling?

Regards,
Markus