linux-kernel - Re: [v3 PATCH] mm: move_pages: report the number of non-attempted pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a9a07fcb-0117-c995-0463-0afc3caa1cde@linux.alibaba.com>
Date:   Mon, 27 Jan 2020 11:55:48 -0800
From:   Yang Shi <yang.shi@...ux.alibaba.com>
To:     Matthew Wilcox <willy@...radead.org>
Cc:     mhocko@...e.com, richardw.yang@...ux.intel.com,
        akpm@...ux-foundation.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [v3 PATCH] mm: move_pages: report the number of non-attempted
 pages



On 1/27/20 11:35 AM, Matthew Wilcox wrote:
>> @@ -1627,8 +1627,18 @@ static int do_pages_move(struct mm_struct *mm, nodemask_t task_nodes,
>>   			start = i;
>>   		} else if (node != current_node) {
>>   			err = do_move_pages_to_node(mm, &pagelist, current_node);
>> -			if (err)
>> +			if (err) {
>> +				/*
>> +				 * Possitive err means the number of failed
> "positive"
>
>> +				 * pages to migrate.  Since we are going to
>> +				 * abort and return the number of non-migrated
>> +				 * pages, so need incude the rest of the
> "need to include"
>
>> +				 * nr_pages that have not attempted as well.
> "have not been attempted"
>
>> @@ -1674,6 +1687,13 @@ static int do_pages_move(struct mm_struct *mm, nodemask_t task_nodes,
>>   
>>   	/* Make sure we do not overwrite the existing error */
>>   	err1 = do_move_pages_to_node(mm, &pagelist, current_node);
>> +	/*
>> +	 * Don't have to report non-attempted pages here since:
>> +	 *     - If the above loop is done gracefully there is not non-attempted
> "all pages have been attempted"
>
>> +	 *       page.
>> +	 *     - If the above loop is aborted to it means more fatal error
> s/to// s/more/a/
>
>> +	 *       happened, should return err.
>> +	 */
> I'd also be tempted to rename "err" to "ret" since it has meanings beyond
> "error" now.

Thanks for catching these problems. Will fix in v4.
>