linux-kernel - [PATCH] kbuild: Include external modules compile flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1580161806-8037-1-git-send-email-gvrose8192@gmail.com>
Date:   Mon, 27 Jan 2020 13:50:06 -0800
From:   Greg Rose <gvrose8192@...il.com>
To:     linux-kernel@...r.kernel.org, dev@...nvswitch.org
Cc:     dsahern@...il.com, Greg Rose <gvrose8192@...il.com>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>
Subject: [PATCH] kbuild: Include external modules compile flags

Since this commit:
'commit 9b9a3f20cbe0 ("kbuild: split final module linking out into Makefile.modfinal")'
at least one out-of-tree external kernel module build fails
during the modfinal make phase because Makefile.modfinal does
not include the ccflags-y variable from the exernal module's Kbuild.
Make sure to include the external kernel module's Kbuild so that the
necessary command line flags from the external module are set.

Reported-by: David Ahern <dsahern@...il.com>
CC: Masahiro Yamada <yamada.masahiro@...ionext.com>
Signed-off-by: Greg Rose <gvrose8192@...il.com>
---
 scripts/Makefile.modfinal | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/scripts/Makefile.modfinal b/scripts/Makefile.modfinal
index 411c1e60..a645ba6 100644
--- a/scripts/Makefile.modfinal
+++ b/scripts/Makefile.modfinal
@@ -21,6 +21,10 @@ __modfinal: $(modules)
 modname = $(notdir $(@:.mod.o=))
 part-of-module = y
 
+# Include the module's Makefile to find KBUILD_EXTRA_SYMBOLS
+include $(if $(wildcard $(KBUILD_EXTMOD)/Kbuild), \
+             $(KBUILD_EXTMOD)/Kbuild)
+
 quiet_cmd_cc_o_c = CC [M]  $@
       cmd_cc_o_c = $(CC) $(c_flags) -c -o $@ $<
 
-- 
1.8.3.1