linux-kernel - Re: [PATCH V3 2/2] soc: imx: increase build coverage for imx8m soc driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <VI1PR04MB70231AC9140BD13FD0539678EE0A0@VI1PR04MB7023.eurprd04.prod.outlook.com>
Date:   Tue, 28 Jan 2020 14:35:41 +0000
From:   Leonard Crestez <leonard.crestez@....com>
To:     Peng Fan <peng.fan@....com>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "arnd@...db.de" <arnd@...db.de>
CC:     "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        dl-linux-imx <linux-imx@....com>,
        "olof@...om.net" <olof@...om.net>,
        Aisheng Dong <aisheng.dong@....com>,
        Abel Vesa <abel.vesa@....com>,
        "krzk@...nel.org" <krzk@...nel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V3 2/2] soc: imx: increase build coverage for imx8m soc
 driver

On 28.01.2020 08:03, Peng Fan wrote:
> From: Peng Fan <peng.fan@....com>
> 
> The soc-imx8.c driver is actually for i.MX8M family, so rename it
> to soc-imx8m.c.
> 
> Use CONFIG_SOC_IMX8M as build gate, not CONFIG_ARCH_MXC, to control
> whether build this driver, also make it possible for compile test.
> 
> Default set it to y for ARCH_MXC && ARM64
> 
> Signed-off-by: Peng Fan <peng.fan@....com>

Reviewed-by: Leonard Crestez <leonard.crestez@....com>

> ---
>   drivers/soc/Makefile                        | 2 +-
>   drivers/soc/imx/Kconfig                     | 9 +++++++++
>   drivers/soc/imx/Makefile                    | 2 +-
>   drivers/soc/imx/{soc-imx8.c => soc-imx8m.c} | 0
>   4 files changed, 11 insertions(+), 2 deletions(-)
>   rename drivers/soc/imx/{soc-imx8.c => soc-imx8m.c} (100%)
> 
> diff --git a/drivers/soc/Makefile b/drivers/soc/Makefile
> index 2ec355003524..614986cd1713 100644
> --- a/drivers/soc/Makefile
> +++ b/drivers/soc/Makefile
> @@ -11,7 +11,7 @@ obj-$(CONFIG_ARCH_DOVE)		+= dove/
>   obj-$(CONFIG_MACH_DOVE)		+= dove/
>   obj-y				+= fsl/
>   obj-$(CONFIG_ARCH_GEMINI)	+= gemini/
> -obj-$(CONFIG_ARCH_MXC)		+= imx/
> +obj-y				+= imx/
>   obj-$(CONFIG_ARCH_IXP4XX)	+= ixp4xx/
>   obj-$(CONFIG_SOC_XWAY)		+= lantiq/
>   obj-y				+= mediatek/
> diff --git a/drivers/soc/imx/Kconfig b/drivers/soc/imx/Kconfig
> index 0281ef9a1800..70019cefa617 100644
> --- a/drivers/soc/imx/Kconfig
> +++ b/drivers/soc/imx/Kconfig
> @@ -17,4 +17,13 @@ config IMX_SCU_SOC
>   	  Controller Unit SoC info module, it will provide the SoC info
>   	  like SoC family, ID and revision etc.
>   
> +config SOC_IMX8M
> +	bool "i.MX8M SoC family support"
> +	depends on ARCH_MXC || COMPILE_TEST
> +	default ARCH_MXC && ARM64
> +	help
> +	  If you say yes here you get support for the NXP i.MX8M family
> +	  support, it will provide the SoC info like SoC family,
> +	  ID and revision etc.
> +
>   endmenu
> diff --git a/drivers/soc/imx/Makefile b/drivers/soc/imx/Makefile
> index cf9ca42ff739..103e2c93c342 100644
> --- a/drivers/soc/imx/Makefile
> +++ b/drivers/soc/imx/Makefile
> @@ -1,5 +1,5 @@
>   # SPDX-License-Identifier: GPL-2.0-only
>   obj-$(CONFIG_HAVE_IMX_GPC) += gpc.o
>   obj-$(CONFIG_IMX_GPCV2_PM_DOMAINS) += gpcv2.o
> -obj-$(CONFIG_ARCH_MXC) += soc-imx8.o
> +obj-$(CONFIG_SOC_IMX8M) += soc-imx8m.o
>   obj-$(CONFIG_IMX_SCU_SOC) += soc-imx-scu.o
> diff --git a/drivers/soc/imx/soc-imx8.c b/drivers/soc/imx/soc-imx8m.c
> similarity index 100%
> rename from drivers/soc/imx/soc-imx8.c
> rename to drivers/soc/imx/soc-imx8m.c