linux-kernel - Re: [PATCH V4 0/4] clk: imx: imx8m: introduce imx8m_clk_hw_composite

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <VI1PR04MB7023201D8DF545198F1B6CB6EE0A0@VI1PR04MB7023.eurprd04.prod.outlook.com>
Date:   Tue, 28 Jan 2020 14:47:59 +0000
From:   Leonard Crestez <leonard.crestez@....com>
To:     Peng Fan <peng.fan@....com>
CC:     "sboyd@...nel.org" <sboyd@...nel.org>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>,
        Abel Vesa <abel.vesa@....com>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        dl-linux-imx <linux-imx@....com>,
        Aisheng Dong <aisheng.dong@....com>,
        "linux-clk@...r.kernel.org" <linux-clk@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Anson Huang <anson.huang@....com>,
        Jacky Bai <ping.bai@....com>,
        "l.stach@...gutronix.de" <l.stach@...gutronix.de>
Subject: Re: [PATCH V4 0/4] clk: imx: imx8m: introduce
 imx8m_clk_hw_composite_core

On 28.01.2020 07:28, Peng Fan wrote:
> From: Peng Fan <peng.fan@....com>

Reviewed-by: Leonard Crestez <leonard.crestez@....com>

> V4:
>   Per Leonard's comments, added new definitions and  _SRC/CG/DIV are
>   alias to the new definition.
>   Did boot test on i.MX8MQ/M/N-EVK
> 
> V3:
>   Add CLK_SET_RATE_NO_REPARENT and CLK_OPS_PARENT_ENABLE for core
>   Avoid break DT for i.MX8MQ
> 
> V2:
>   Rename imx8m_clk_hw_core_composite to imx8m_clk_hw_composite_core
>   Add Abel's tag
> 
> To i.MX8M family, there are different types of clock slices,
> bus/core/ip and etc. Currently, the imx8m_clk_hw_composite
> api could only handle bus and ip clock slice, it could
> not handle core slice. The difference is core slice not have
> pre divider and the width of post divider is 3 bits.
> 
> To simplify code and reuse imx8m_clk_hw_composite, introduce a
> flag IMX_COMPOSITE_CORE to differentiate the slices.
> 
> With this new helper, we could simplify i.MX8M SoC clk drivers.
> 
> 
> Peng Fan (4):
>    clk: imx: composite-8m: add imx8m_clk_hw_composite_core
>    clk: imx: imx8mq: use imx8m_clk_hw_composite_core
>    clk: imx: imx8mm: use imx8m_clk_hw_composite_core
>    clk: imx: imx8mn: use imx8m_clk_hw_composite_core
> 
>   drivers/clk/imx/clk-composite-8m.c       | 18 ++++++++++++----
>   drivers/clk/imx/clk-imx8mm.c             | 35 +++++++++++++++++++-------------
>   drivers/clk/imx/clk-imx8mn.c             | 19 +++++++++--------
>   drivers/clk/imx/clk-imx8mq.c             | 34 +++++++++++++++++--------------
>   drivers/clk/imx/clk.h                    | 13 ++++++++++--
>   include/dt-bindings/clock/imx8mm-clock.h |  7 ++++++-
>   include/dt-bindings/clock/imx8mn-clock.h |  5 ++++-
>   include/dt-bindings/clock/imx8mq-clock.h |  7 ++++++-
>   8 files changed, 92 insertions(+), 46 deletions(-)
>