linux-kernel - Re: [PATCH v2 10/10] gcov: Remove old GCC 3.4 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <28e3e35c-1a26-5f87-064e-39f8a1fc9105@linux.ibm.com>
Date:   Tue, 28 Jan 2020 15:56:06 +0100
From:   Peter Oberparleiter <oberpar@...ux.ibm.com>
To:     Will Deacon <will@...nel.org>, linux-kernel@...r.kernel.org
Cc:     linux-arch@...r.kernel.org, kernel-team@...roid.com,
        Michael Ellerman <mpe@...erman.id.au>,
        Peter Zijlstra <peterz@...radead.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Segher Boessenkool <segher@...nel.crashing.org>,
        Christian Borntraeger <borntraeger@...ibm.com>,
        Luc Van Oostenryck <luc.vanoostenryck@...il.com>,
        Arnd Bergmann <arnd@...db.de>,
        Masahiro Yamada <masahiroy@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>
Subject: Re: [PATCH v2 10/10] gcov: Remove old GCC 3.4 support

On 23.01.2020 16:33, Will Deacon wrote:
> The kernel requires at least GCC 4.8 in order to build, and so there is
> no need to cater for the pre-4.7 gcov format.
> 
> Remove the obsolete code.
> 
> Cc: Peter Oberparleiter <oberpar@...ux.ibm.com>
> Signed-off-by: Will Deacon <will@...nel.org>
> ---
>  kernel/gcov/Kconfig   |  24 --
>  kernel/gcov/Makefile  |   3 +-
>  kernel/gcov/gcc_3_4.c | 573 ------------------------------------------
>  3 files changed, 1 insertion(+), 599 deletions(-)
>  delete mode 100644 kernel/gcov/gcc_3_4.c

Acked-by: Peter Oberparleiter <oberpar@...ux.ibm.com>

Compiles, boots, produces coverage output on a s390 system with a
recent-ish GCC version, so that change is fine by me.

There's a final reference to the gcc_3_4.c file in the gcc_4_7.c header
comment, but its probably not worth the extra effort to adjust that as well.

-- 
Peter Oberparleiter
Linux on Z Development - IBM Germany