linux-kernel - Re: [PATCH] fork.c: Use RCU_INIT_POINTER() instead of rcu_access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200128145946.GE17943@redhat.com>
Date:   Tue, 28 Jan 2020 15:59:46 +0100
From:   Oleg Nesterov <oleg@...hat.com>
To:     madhuparnabhowmik10@...il.com
Cc:     christian.brauner@...ntu.com, mingo@...nel.org,
        linux-kernel@...r.kernel.org, paulmck@...nel.org,
        joel@...lfernandes.org, frextrite@...il.com, rcu@...r.kernel.org,
        linux-kernel-mentees@...ts.linuxfoundation.org
Subject: Re: [PATCH] fork.c: Use RCU_INIT_POINTER() instead of
 rcu_access_pointer()

On 01/27, madhuparnabhowmik10@...il.com wrote:
>
> --- a/kernel/fork.c
> +++ b/kernel/fork.c
> @@ -1508,7 +1508,7 @@ static int copy_sighand(unsigned long clone_flags, struct task_struct *tsk)
>  		return 0;
>  	}
>  	sig = kmem_cache_alloc(sighand_cachep, GFP_KERNEL);
> -	rcu_assign_pointer(tsk->sighand, sig);
> +	RCU_INIT_POINTER(tsk->sighand, sig);

Acked-by: Oleg Nesterov <oleg@...hat.com>