[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <c76577ea-4d55-a3ce-66b7-02c1cb05c2da@gmail.com>
Date: Tue, 28 Jan 2020 10:41:36 +0300
From: Pavel Begunkov <asml.silence@...il.com>
To: Jens Axboe <axboe@...nel.dk>, io-uring@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/2] io-wq sharing
On 28/01/2020 03:29, Jens Axboe wrote:
> On 1/27/20 5:15 PM, Pavel Begunkov wrote:
>> rip-off of Jens io-wq sharing patches allowing multiple io_uring
>> instances to be bound to a single io-wq. The differences are:
>> - io-wq, which we would like to be shared, is passed as io_uring fd
>> - fail, if can't share. IMHO, it's always better to fail fast and loud
>>
>> I didn't tested it after rebasing, but hopefully won't be a problem.
>>
>> p.s. on top of ("io_uring/io-wq: don't use static creds/mm assignments")
>
> Applied with the following changes:
>
> - Return -EINVAL for invalid ringfd when attach is specified
> - Remove the wq_fd check for attach not specified
The check was there to be able to reuse the wq_fd field, if the flag isn't
specified.
>
> Tested here, works for me. Pushing out the updated test case.
>
Thanks!
--
Pavel Begunkov
Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)
Powered by blists - more mailing lists