linux-kernel - Re: [Patch v2 1/4] mm/migrate.c: not necessary to check start and i

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fa4b94a7-4b70-ab01-e5e5-8eeb18b15c62@redhat.com>
Date:   Tue, 28 Jan 2020 11:04:23 +0100
From:   David Hildenbrand <david@...hat.com>
To:     Wei Yang <richardw.yang@...ux.intel.com>, akpm@...ux-foundation.org
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org, mhocko@...e.com,
        yang.shi@...ux.alibaba.com, rientjes@...gle.com
Subject: Re: [Patch v2 1/4] mm/migrate.c: not necessary to check start and i

On 22.01.20 02:16, Wei Yang wrote:
> Till here, i must no less than start. And if i equals to start,
> store_status() would always return 0.

I'd suggest

"
mm/migrate.c: no need to check for i > start in do_pages_move()

At this point, we always have i >= start. If i == start, store_status()
will return 0. So we can drop the check for i > start.
"

Reviewed-by: David Hildenbrand <david@...hat.com>

> 
> Remove some unnecessary check to make it easy to read and prepare for
> further cleanup.
> 
> Signed-off-by: Wei Yang <richardw.yang@...ux.intel.com>
> Acked-by: Michal Hocko <mhocko@...e.com>
> ---
>  mm/migrate.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/mm/migrate.c b/mm/migrate.c
> index 430fdccc733e..4c2a21856717 100644
> --- a/mm/migrate.c
> +++ b/mm/migrate.c
> @@ -1661,11 +1661,9 @@ static int do_pages_move(struct mm_struct *mm, nodemask_t task_nodes,
>  		err = do_move_pages_to_node(mm, &pagelist, current_node);
>  		if (err)
>  			goto out;
> -		if (i > start) {
> -			err = store_status(status, start, current_node, i - start);
> -			if (err)
> -				goto out;
> -		}
> +		err = store_status(status, start, current_node, i - start);
> +		if (err)
> +			goto out;
>  		current_node = NUMA_NO_NODE;
>  	}
>  out_flush:
> 


-- 
Thanks,

David / dhildenb