linux-kernel - Re: [PATCH 09/22] staging: exfat: Rename variable "Size" to "size"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <287916429826dd2f14d82f9b7b6b15a9cace2734.camel@gmail.com>
Date:   Wed, 29 Jan 2020 16:10:39 +0530
From:   Pragat Pandya <pragat.pandya@...il.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     valdis.kletnieks@...edu, gregkh@...uxfoundation.org,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        skhan@...uxfoundation.org, linux-fsdevel@...r.kernel.org,
        linux-kernel-mentees@...ts.linuxfoundation.org
Subject: Re: [PATCH 09/22] staging: exfat: Rename variable "Size" to "size"

On Mon, 2020-01-27 at 14:57 +0300, Dan Carpenter wrote:
> On Mon, Jan 27, 2020 at 03:43:30PM +0530, Pragat Pandya wrote:
> > Change all the occurences of "Size" to "size" in exfat.
> > 
> > Signed-off-by: Pragat Pandya <pragat.pandya@...il.com>
> > ---
> >  drivers/staging/exfat/exfat.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/staging/exfat/exfat.h
> > b/drivers/staging/exfat/exfat.h
> > index 52f314d50b91..a228350acdb4 100644
> > --- a/drivers/staging/exfat/exfat.h
> > +++ b/drivers/staging/exfat/exfat.h
> > @@ -233,7 +233,7 @@ struct date_time_t {
> >  
> >  struct part_info_t {
> >  	u32      offset;    /* start sector number of the partition */
> > -	u32      Size;      /* in sectors */
> > +	u32      size;      /* in sectors */
> >  };
> 
> We just renamed all the struct members of this without changing any
> users.  Which suggests that this is unused and can be deleted.
> 
> regards,
> dan carpenter
> 
Can I just drop this commit from this patchset and do a separate patch
to remove the unused structure?

regards,
pragat pandya