[<prev] [next>] [day] [month] [year] [list]
Message-ID: <87sgjyzewl.fsf@osv.gnss.ru>
Date: Wed, 29 Jan 2020 14:21:46 +0300
From: Sergey Organov <sorganov@...il.com>
To: linux-usb@...r.kernel.org
Cc: linux-kernel@...r.kernel.org,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Felipe Balbi <balbi@...nel.org>,
Michał Mirosław <mirq-linux@...e.qmqm.pl>,
linux-serial@...r.kernel.org
Subject: [PATCH v3] usb: gadget: serial: fix Tx stall after buffer overflow
Symptom: application opens /dev/ttyGS0 and starts sending (writing) to
it while either USB cable is not connected, or nobody listens on the
other side of the cable. If driver circular buffer overflows before
connection is established, no data will be written to the USB layer
until/unless /dev/ttyGS0 is closed and re-opened again by the
application (the latter besides having no means of being notified about
the event of establishing of the connection.)
Fix: on open and/or connect, kick Tx to flush circular buffer data to
USB layer.
Signed-off-by: Sergey Organov <sorganov@...il.com>
Reviewed-by: Michał Mirosław <mirq-linux@...e.qmqm.pl>
---
Changes in v3:
- Add Reviewed-by: Michał Mirosław <mirq-linux@...e.qmqm.pl>
Changes in v2:
- Add comment to document why tty_wakeup() is kept in place
- Don't add debug print
- Remove NOTE from description
drivers/usb/gadget/function/u_serial.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/function/u_serial.c b/drivers/usb/gadget/function/u_serial.c
index f986e5c..8167d37 100644
--- a/drivers/usb/gadget/function/u_serial.c
+++ b/drivers/usb/gadget/function/u_serial.c
@@ -561,8 +561,10 @@ static int gs_start_io(struct gs_port *port)
port->n_read = 0;
started = gs_start_rx(port);
- /* unblock any pending writes into our circular buffer */
if (started) {
+ gs_start_tx(port);
+ /* Unblock any pending writes into our circular buffer, in case
+ * we didn't in gs_start_tx() */
tty_wakeup(port->port.tty);
} else {
gs_free_requests(ep, head, &port->read_allocated);
--
2.10.0.1.g57b01a3
Powered by blists - more mailing lists