linux-kernel - Re: [PATCH 03/28] ata: make SATA_PMP option selectable only if any SATA host driver is enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yq1zhe76lco.fsf@oracle.com>
Date:   Tue, 28 Jan 2020 21:35:19 -0500
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
Cc:     Jens Axboe <axboe@...nel.dk>,
        Michael Schmitz <schmitzmic@...il.com>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>
Subject: Re: [PATCH 03/28] ata: make SATA_PMP option selectable only if any SATA host driver is enabled


Bartlomiej,

> diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
> index a7881f8eb05e..1b6eaf8da5fa 100644
> --- a/drivers/scsi/Kconfig
> +++ b/drivers/scsi/Kconfig
> @@ -989,6 +989,7 @@ config SCSI_SYM53C8XX_MMIO
>  config SCSI_IPR
>  	tristate "IBM Power Linux RAID adapter support"
>  	depends on PCI && SCSI && ATA
> +	select SATA_HOST
>  	select FW_LOADER
>  	select IRQ_POLL
>  	select SGL_ALLOC
> diff --git a/drivers/scsi/libsas/Kconfig b/drivers/scsi/libsas/Kconfig
> index 5c6a5eff2f8e..052ee3a26f6e 100644
> --- a/drivers/scsi/libsas/Kconfig
> +++ b/drivers/scsi/libsas/Kconfig
> @@ -19,6 +19,7 @@ config SCSI_SAS_ATA
>  	bool "ATA support for libsas (requires libata)"
>  	depends on SCSI_SAS_LIBSAS
>  	depends on ATA = y || ATA = SCSI_SAS_LIBSAS
> +	select SATA_HOST
>  	help
>  		Builds in ATA support into libsas.  Will necessitate
>  		the loading of libata along with libsas.

SCSI bits look fine.

Reviewed-by: Martin K. Petersen <martin.petersen@...cle.com>

-- 
Martin K. Petersen	Oracle Linux Engineering