linux-kernel - Re: [PATCH 12/28] ata: start separating SATA specific code from libata-core.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200129172614.GH12616@infradead.org>
Date:   Wed, 29 Jan 2020 09:26:14 -0800
From:   Christoph Hellwig <hch@...radead.org>
To:     Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
Cc:     Jens Axboe <axboe@...nel.dk>,
        Michael Schmitz <schmitzmic@...il.com>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 12/28] ata: start separating SATA specific code from
 libata-core.c

On Tue, Jan 28, 2020 at 02:33:27PM +0100, Bartlomiej Zolnierkiewicz wrote:
> Start separating SATA specific code from libata-core.c:
> 
> * move following functions to libata-core-sata.c:

Why not call this libata-sata.c?  If it is SATA specific it can't be
that core :)

> + *  libata-core-sata.c - SATA specific part of ATA helper library

No need for file names in top of file headers.

> +/*
> + * Core layer (SATA specific part) - drivers/ata/libata-core-sata.c
> + */
> +#ifdef CONFIG_SATA_HOST
> +extern int sata_link_scr_lpm(struct ata_link *link, enum ata_lpm_policy policy,
> +			     bool spm_wakeup);
> +extern int ata_slave_link_init(struct ata_port *ap);
> +extern void ata_tf_to_fis(const struct ata_taskfile *tf,
> +			  u8 pmp, int is_cmd, u8 *fis);
> +extern void ata_tf_from_fis(const u8 *fis, struct ata_taskfile *tf);
>  extern bool sata_lpm_ignore_phy_events(struct ata_link *link);
> +#endif

No need for the ifdef.