linux-kernel - Re: [PATCH v10 7/8] hugetlb_cgroup: Add hugetlb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.2001291257510.175731@chino.kir.corp.google.com>
Date:   Wed, 29 Jan 2020 13:00:16 -0800 (PST)
From:   David Rientjes <rientjes@...gle.com>
To:     Sandipan Das <sandipan@...ux.ibm.com>
cc:     Mina Almasry <almasrymina@...gle.com>, mike.kravetz@...cle.com,
        shakeelb@...gle.com, shuah@...nel.org, gthelen@...gle.com,
        akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
        linux-mm@...ck.org, linux-kselftest@...r.kernel.org,
        cgroups@...r.kernel.org, aneesh.kumar@...ux.vnet.ibm.com
Subject: Re: [PATCH v10 7/8] hugetlb_cgroup: Add hugetlb_cgroup reservation
 tests

On Thu, 23 Jan 2020, Sandipan Das wrote:

> > The tests use both shared and private mapped hugetlb memory, and
> > monitors the hugetlb usage counter as well as the hugetlb reservation
> > counter. They test different configurations such as hugetlb memory usage
> > via hugetlbfs, or MAP_HUGETLB, or shmget/shmat, and with and without
> > MAP_POPULATE.
> > 
> > Also add test for hugetlb reservation reparenting, since this is
> > a subtle issue.
> > 
> > Signed-off-by: Mina Almasry <almasrymina@...gle.com>
> > 
> 
> For powerpc64, either 16MB/16GB or 2MB/1GB huge pages are supported depending
> on the MMU type (Hash or Radix). I was just running these tests on a powerpc64
> system with Hash MMU and ran into problems because the tests assume that the
> hugepage size is always 2MB. Can you determine the huge page size at runtime?
> 

I assume this is only testing failures of the tools/testing/selftests 
additions that hardcode 2MB paths and not a kernel problem?  In other 
words, you can still boot, reserve, alloc, and free hugetlb pages on ppc 
after this patchset without using the selftests?