linux-kernel - Re: [PATCH v4 07/12] tracing: Add synth_event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200129160915.4ebe0f08@gandalf.local.home>
Date:   Wed, 29 Jan 2020 16:09:14 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Tom Zanussi <zanussi@...nel.org>
Cc:     artem.bityutskiy@...ux.intel.com, mhiramat@...nel.org,
        linux-kernel@...r.kernel.org, linux-rt-users@...r.kernel.org
Subject: Re: [PATCH v4 07/12] tracing: Add synth_event_trace() and related
 functions

On Wed, 29 Jan 2020 12:59:27 -0600
Tom Zanussi <zanussi@...nel.org> wrote:

> +static struct synth_field *find_synth_field(struct synth_event *event,
> +					    const char *field_name)
> +{
> +	struct synth_field *field = NULL;
> +	unsigned int i;
> +
> +	for (i = 0; i < event->n_fields; i++) {
> +		field = event->fields[i];
> +		if (strcmp(field->name, field_name) == 0)
> +			return field;
> +	}
> +
> +	return NULL;
> +}

Why duplicate all theses functions and not use them in the
synth_event_trace() directly?

-- Steve