linux-kernel - Re: [PATCH 3/4] i2c: cadence: Implement save restore

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 30 Jan 2020 09:21:01 +0100
From:   Wolfram Sang <wsa@...-dreams.de>
To:     shubhrajyoti.datta@...il.com
Cc:     linux-kernel@...r.kernel.org, linux-i2c@...r.kernel.org,
        michal.simek@...inx.com,
        Shubhrajyoti Datta <shubhrajyoti.datta@...inx.com>,
        Shubhrajyoti Datta <shubhraj@...inx.com>
Subject: Re: [PATCH 3/4] i2c: cadence: Implement save restore

On Mon, Dec 09, 2019 at 04:10:51PM +0530, shubhrajyoti.datta@...il.com wrote:
> From: Shubhrajyoti Datta <shubhrajyoti.datta@...inx.com>
> 
> Implement save restore for i2c module.
> Since we have only a couple of registers
> an unconditional restore is done.

The patch description misses an explanation *why* this is needed. From a
distance looks like a bugfix, so a Fixes tag may be needed, too.

> 
> Acked-by: Michal Simek <michal.simek@...inx.com>
> Signed-off-by: Shubhrajyoti Datta <shubhraj@...inx.com>
> Signed-off-by: Michal Simek <michal.simek@...inx.com>
> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@...inx.com>

This is messy. Ack + SoB from Michal. Two xilinx-SoBs from you. Please
fix.


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)