linux-kernel - RE: [PATCH] hpet: Fix struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b04253f40d9e49e597af925599bd4964@AcuMS.aculab.com>
Date:   Thu, 30 Jan 2020 10:09:45 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'Greg KH' <gregkh@...uxfoundation.org>,
        Eric Biggers <ebiggers@...nel.org>
CC:     Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>,
        "gustavo@...eddedor.com" <gustavo@...eddedor.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] hpet: Fix struct_size() in kzalloc()

...
> > > -	hpetp = kzalloc(struct_size(hpetp, hp_dev, hdp->hd_nirqs - 1),
> > > +	hpetp = kzalloc(struct_size(hpetp, hp_dev, hdp->hd_nirqs),
> > >  			GFP_KERNEL);
> > >
> > >  	if (!hpetp)
> > > --
> >
> > Yep, "char: hpet: Use flexible-array member" started causing random boot
> > failures on mainline for me.  Tetsuo beat me to sending the fix.
> >
> > Only thing I'll add is that GFP_KERNEL can now fit on the previous line.
> 
> Gustavo already sent a fix for this, I didn't realize it was causing
> boot problems, I'll forward it on to Linus soon.

grep -r --include '*.c' 'struct_size.*- 1'
gives 4 other matches.
I bet they all have the same bug.
There might be others that simple pattern doesn't find.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)