linux-kernel - Re: [PATCH 03/17] follow_automount(): get rid of dead^Wstillborn code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200130143853.ferv2mtgwka5q4lx@wittgenstein>
Date:   Thu, 30 Jan 2020 15:38:53 +0100
From:   Christian Brauner <christian.brauner@...ntu.com>
To:     Al Viro <viro@...IV.linux.org.uk>
Cc:     linux-fsdevel@...r.kernel.org,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        linux-kernel@...r.kernel.org, Aleksa Sarai <cyphar@...har.com>,
        David Howells <dhowells@...hat.com>,
        Eric Biederman <ebiederm@...ssion.com>
Subject: Re: [PATCH 03/17] follow_automount(): get rid of dead^Wstillborn code

On Sun, Jan 19, 2020 at 03:17:15AM +0000, Al Viro wrote:
> From: Al Viro <viro@...iv.linux.org.uk>
> 
> 1) no instances of ->d_automount() have ever made use of the "return
> ERR_PTR(-EISDIR) if you don't feel like mounting anything" - that's
> a rudiment of plans that got superseded before the thing went into
> the tree.  Despite the comment in follow_automount(), autofs has
> never done that.
> 
> 2) if there's no ->d_automount() in dentry_operations, filesystems
> should not set DCACHE_NEED_AUTOMOUNT in the first place.  None have
> ever done so...
> 
> Signed-off-by: Al Viro <viro@...iv.linux.org.uk>

I can't speak to 1) but code seems correct:
Acked-by: Christian Brauner <christian.brauner@...ntu.com>