linux-kernel - Re: [PATCH 04/17] follow_automount() doesn't need the entire nameidata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200130155519.GC23230@ZenIV.linux.org.uk>
Date:   Thu, 30 Jan 2020 15:55:19 +0000
From:   Al Viro <viro@...iv.linux.org.uk>
To:     Christian Brauner <christian.brauner@...ntu.com>
Cc:     linux-fsdevel@...r.kernel.org,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        linux-kernel@...r.kernel.org, Aleksa Sarai <cyphar@...har.com>,
        David Howells <dhowells@...hat.com>,
        Eric Biederman <ebiederm@...ssion.com>
Subject: Re: [PATCH 04/17] follow_automount() doesn't need the entire
 nameidata

On Thu, Jan 30, 2020 at 03:38:25PM +0000, Al Viro wrote:
> On Thu, Jan 30, 2020 at 03:45:20PM +0100, Christian Brauner wrote:
> > > -	nd->total_link_count++;
> > > -	if (nd->total_link_count >= 40)
> > > +	if (count && *count++ >= 40)
> > 
> > He, side-effects galore. :)
> > Isn't this incrementing the address but you want to increment the
> > counter?
> > Seems like this should be
> > 
> > if (count && (*count)++ >= 40)
> 
> Nice catch; incidentally, it means that usual testsuites (xfstests,
> LTP) are missing the automount loop detection.  Hmm...

Fix folded and pushed (the series in #next.namei now, on top of
#work.openat2 + #fixes)