linux-kernel - Re: [PATCH] dmaengine: idxd: fix boolconv.cocci warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 30 Jan 2020 09:13:03 -0700
From:   Dave Jiang <dave.jiang@...el.com>
To:     Julia Lawall <julia.lawall@...ia.fr>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        Vinod Koul <vkoul@...nel.org>,
        Dan Williams <dan.j.williams@...el.com>,
        dmaengine@...r.kernel.org
Subject: Re: [PATCH] dmaengine: idxd: fix boolconv.cocci warnings



On 1/30/20 7:44 AM, Julia Lawall wrote:
> From: kbuild test robot <lkp@...el.com>
> 
> Remove unneeded conversion to bool
> 
> Generated by: scripts/coccinelle/misc/boolconv.cocci
> 
> CC: Dave Jiang <dave.jiang@...el.com>
> Signed-off-by: kbuild test robot <lkp@...el.com>
> Signed-off-by: Julia Lawall <julia.lawall@...ia.fr>

Acked-by: Dave Jiang <dave.jiang@...el.com>

> ---
> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   39bed42de2e7d74686a2d5a45638d6a5d7e7d473
> commit: 42d279f9137ab7d5503836baec2739284b278d8f dmaengine: idxd: add char driver to expose submission portal to userland
> :::::: branch date: 11 hours ago
> :::::: commit date: 6 days ago
> 
> Please take the patch only if it's a positive warning. Thanks!
> 
>   sysfs.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/drivers/dma/idxd/sysfs.c
> +++ b/drivers/dma/idxd/sysfs.c
> @@ -66,7 +66,7 @@ static inline bool is_idxd_wq_dmaengine(
> 
>   static inline bool is_idxd_wq_cdev(struct idxd_wq *wq)
>   {
> -	return wq->type == IDXD_WQT_USER ? true : false;
> +	return wq->type == IDXD_WQT_USER;
>   }
> 
>   static int idxd_config_bus_match(struct device *dev,
>