linux-kernel - Re: [PATCH v4 04/12] tracing: Add dynamic event command creation interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200129215852.53063246@rorschach.local.home>
Date:   Wed, 29 Jan 2020 21:58:52 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Masami Hiramatsu <mhiramat@...nel.org>
Cc:     Tom Zanussi <zanussi@...nel.org>, artem.bityutskiy@...ux.intel.com,
        linux-kernel@...r.kernel.org, linux-rt-users@...r.kernel.org
Subject: Re: [PATCH v4 04/12] tracing: Add dynamic event command creation
 interface

On Thu, 30 Jan 2020 11:40:28 +0900
Masami Hiramatsu <mhiramat@...nel.org> wrote:

> > +int dynevent_arg_add(struct dynevent_cmd *cmd,
> > +		     struct dynevent_arg *arg)
> > +{
> > +	int ret = 0;
> > +	int delta;
> > +	char *q;
> > +
> > +	if (arg->check_arg) {
> > +		ret = arg->check_arg(arg);  
> 
> Hmm, this seems a bit odd. The check_arg() arg object member check
> the validity of the object itself. What about moving those checker
> into dynevent_cmd instead of dynevent_arg?
> (Or, just pass the appropriate checker as the 3rd parameter of
>  this function)

Masami,

Thanks for reviewing these patches.

Tom,

Please send updates on top of this series. I've already pulled them in
my queue and there going through my test suite now. It will be easier
just to add changes on top than to send another version at this point.

You can see what I'm testing via my repo on branch ftrace/core.

-- Steve