linux-kernel - Re: [PATCH v3 2/3] clk: rockchip: convert basic pll lock_wait to use regmap_read_poll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200130171934.0CCB920707@mail.kernel.org>
Date:   Thu, 30 Jan 2020 09:19:33 -0800
From:   Stephen Boyd <sboyd@...nel.org>
To:     Heiko Stuebner <heiko@...ech.de>, linux-clk@...r.kernel.org
Cc:     linux-arm-kernel@...ts.infradead.org,
        linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org,
        mturquette@...libre.com, heiko@...ech.de,
        christoph.muellner@...obroma-systems.com, zhangqing@...k-chips.com,
        robin.murphy@....com,
        Heiko Stuebner <heiko.stuebner@...obroma-systems.com>
Subject: Re: [PATCH v3 2/3] clk: rockchip: convert basic pll lock_wait to use regmap_read_poll_timeout

Quoting Heiko Stuebner (2020-01-29 08:38:20)
> From: Heiko Stuebner <heiko.stuebner@...obroma-systems.com>
> 
> Instead of open coding the polling of the lock status, use the
> handy regmap_read_poll_timeout for this. As the pll locking is
> normally blazingly fast and we don't want to incur additional
> delays, we're not doing any sleeps similar to for example the imx
> clk-pllv4 and define a very safe but still short timeout of 1ms.
> 
> Suggested-by: Stephen Boyd <sboyd@...nel.org>
> Signed-off-by: Heiko Stuebner <heiko.stuebner@...obroma-systems.com>
> ---

Reviewed-by: Stephen Boyd <sboyd@...nel.org>