linux-kernel - Re: [PATCH AUTOSEL 5.4 016/187] x86/intel: Disable HPET on Intel Ice Lake platforms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJvTdKkV4GgnE80PKuUFogR=Q+77-z5YHLhCaCSW=rjaV1owzQ@mail.gmail.com>
Date:   Thu, 30 Jan 2020 14:50:58 -0500
From:   Len Brown <lenb@...nel.org>
To:     Sasha Levin <sashal@...nel.org>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        stable@...r.kernel.org,
        Kai-Heng Feng <kai.heng.feng@...onical.com>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Borislav Petkov <bp@...en8.de>, feng.tang@...el.com,
        harry.pan@...el.com, "H. Peter Anvin" <hpa@...or.com>,
        Ingo Molnar <mingo@...nel.org>, linux-pci@...r.kernel.org
Subject: Re: [PATCH AUTOSEL 5.4 016/187] x86/intel: Disable HPET on Intel Ice
 Lake platforms

Can somebody point to an ICL system that is running production-level
firmware that exhibits this issue?

The hardware people are telling me that zero such systems should exist.

(The reported symptom that I've seen is that the TSC vs HPET
comparison fails, and Linux keeps the (bad) HPET and disables the
(good) TSC)

thanks,
-Len

On Fri, Dec 27, 2019 at 12:41 PM Sasha Levin <sashal@...nel.org> wrote:
>
> From: Kai-Heng Feng <kai.heng.feng@...onical.com>
>
> [ Upstream commit e0748539e3d594dd26f0d27a270f14720b22a406 ]
>
> Like CFL and CFL-H, ICL SoC has skewed HPET timer once it hits PC10.
> So let's disable HPET on ICL.
>
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@...onical.com>
> Cc: Linus Torvalds <torvalds@...ux-foundation.org>
> Cc: Peter Zijlstra <peterz@...radead.org>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: bp@...en8.de
> Cc: feng.tang@...el.com
> Cc: harry.pan@...el.com
> Cc: hpa@...or.com
> Link: https://lkml.kernel.org/r/20191129062303.18982-2-kai.heng.feng@canonical.com
> Signed-off-by: Ingo Molnar <mingo@...nel.org>
> Signed-off-by: Sasha Levin <sashal@...nel.org>
> ---
>  arch/x86/kernel/early-quirks.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/arch/x86/kernel/early-quirks.c b/arch/x86/kernel/early-quirks.c
> index 606711f5ebf8..2f9ec14be3b1 100644
> --- a/arch/x86/kernel/early-quirks.c
> +++ b/arch/x86/kernel/early-quirks.c
> @@ -714,6 +714,8 @@ static struct chipset early_qrk[] __initdata = {
>                 PCI_CLASS_BRIDGE_HOST, PCI_ANY_ID, 0, force_disable_hpet},
>         { PCI_VENDOR_ID_INTEL, 0x3ec4,
>                 PCI_CLASS_BRIDGE_HOST, PCI_ANY_ID, 0, force_disable_hpet},
> +       { PCI_VENDOR_ID_INTEL, 0x8a12,
> +               PCI_CLASS_BRIDGE_HOST, PCI_ANY_ID, 0, force_disable_hpet},
>         { PCI_VENDOR_ID_BROADCOM, 0x4331,
>           PCI_CLASS_NETWORK_OTHER, PCI_ANY_ID, 0, apple_airport_reset},
>         {}
> --
> 2.20.1
>


-- 
Len Brown, Intel Open Source Technology Center