linux-kernel - Re: [PATCH 2/2] rcu/nocb: Add missing annotation for rcu_nocb_bypass

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200131005952.GD83200@debian-boqun.qqnc3lrjykvubdpftowmye0fmh.lx.internal.cloudapp.net>
Date:   Fri, 31 Jan 2020 08:59:52 +0800
From:   Boqun Feng <boqun.feng@...il.com>
To:     Jules Irenge <jbi.octave@...il.com>
Cc:     viro@...iv.linux.org.uk, linux-kernel@...r.kernel.org,
        joel@...lfernandes.org, jiangshanlai@...il.com,
        mathieu.desnoyers@...icios.com, rostedt@...dmis.org,
        josh@...htriplett.org, paulmck@...nel.org, rcu@...r.kernel.org
Subject: Re: [PATCH 2/2] rcu/nocb: Add missing annotation for
 rcu_nocb_bypass_unlock()

On Thu, Jan 30, 2020 at 12:30:09AM +0000, Jules Irenge wrote:
> Sparse reports warning at rcu_nocb_bypass_unlock()
> 
> warning: context imbalance in rcu_nocb_bypass_unlock() - unexpected unlock
> 
> The root cause is a missing annotation of rcu_nocb_bypass_unlock()
> which causes the warning.
> 
> Add the missing __releases(&rdp->nocb_bypass_lock) annotation.
> 
> Signed-off-by: Jules Irenge <jbi.octave@...il.com>

Acked-by: Boqun Feng <boqun.feng@...il.com>

> ---
>  kernel/rcu/tree_plugin.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/kernel/rcu/tree_plugin.h b/kernel/rcu/tree_plugin.h
> index 9d21cb07d57c..8783d19a58b2 100644
> --- a/kernel/rcu/tree_plugin.h
> +++ b/kernel/rcu/tree_plugin.h
> @@ -1553,6 +1553,7 @@ static bool rcu_nocb_bypass_trylock(struct rcu_data *rdp)
>   * Release the specified rcu_data structure's ->nocb_bypass_lock.
>   */
>  static void rcu_nocb_bypass_unlock(struct rcu_data *rdp)
> +	__releases(&rdp->nocb_bypass_lock)
>  {
>  	lockdep_assert_irqs_disabled();
>  	raw_spin_unlock(&rdp->nocb_bypass_lock);
> -- 
> 2.24.1
>