lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 31 Jan 2020 14:57:46 +0100 From: Andrew Lunn <andrew@...n.ch> To: Dan Carpenter <dan.carpenter@...cle.com> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Ajay Gupta <ajayg@...dia.com>, "David S. Miller" <davem@...emloft.net>, "Rafael J. Wysocki" <rafael@...nel.org>, Iyappan Subramanian <iyappan@...amperecomputing.com>, Keyur Chudgar <keyur@...amperecomputing.com>, Quan Nguyen <quan@...amperecomputing.com>, Steve Glendinning <steve.glendinning@...well.net>, Jassi Brar <jaswinder.singh@...aro.org>, Ilias Apalodimas <ilias.apalodimas@...aro.org>, Giuseppe Cavallaro <peppe.cavallaro@...com>, Alexandre Torgue <alexandre.torgue@...com>, Jose Abreu <joabreu@...opsys.com>, Maxime Coquelin <mcoquelin.stm32@...il.com>, Dmitry Torokhov <dmitry.torokhov@...il.com>, Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Sakari Ailus <sakari.ailus@...ux.intel.com>, Heikki Krogerus <heikki.krogerus@...ux.intel.com>, linux-kernel@...r.kernel.org, netdev@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com, kernel-janitors@...r.kernel.org Subject: Re: [PATCH net] device property: change device_get_phy_mode() to prevent signedess bugs > diff --git a/drivers/net/ethernet/apm/xgene-v2/main.c b/drivers/net/ethernet/apm/xgene-v2/main.c > index c48f60996761..706602918dd1 100644 > --- a/drivers/net/ethernet/apm/xgene-v2/main.c > +++ b/drivers/net/ethernet/apm/xgene-v2/main.c > @@ -15,7 +15,7 @@ static int xge_get_resources(struct xge_pdata *pdata) > { > struct platform_device *pdev; > struct net_device *ndev; > - int phy_mode, ret = 0; > + int ret = 0; > struct resource *res; > struct device *dev; Hi Dan DaveM likes reverse christmas tree. So you need to move ret later to keep the tree. Apart from that: Reviewed-by: Andrew Lunn <andrew@...n.ch> Andrew
Powered by blists - more mailing lists