linux-kernel - Re: [PATCH] tools: perf: add missing unlock to maps_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <16ffc41db20.2bfa.85c738e3968116fc5c0dc2de74002084@kernel.wtf>
Date:   Fri, 31 Jan 2020 18:42:39 +0300
From:   Cengiz Can <cengiz@...nel.wtf>
To:     Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>
CC:     <linux-kernel@...r.kernel.org>, <bpf@...r.kernel.org>,
        <netdev@...r.kernel.org>
Subject: Re: [PATCH] tools: perf: add missing unlock to maps__insert error case


On January 31, 2020 11:43:46 Arnaldo Carvalho de Melo 
<arnaldo.melo@...il.com> wrote:

> Em Fri, Jan 31, 2020 at 09:38:58AM +0100, Arnaldo Carvalho de Melo escreveu:
>> Em Mon, Jan 20, 2020 at 05:15:54PM +0300, Cengiz Can escreveu:
>>> Please tell me if the `__maps__free_maps_by_name` frees the
>>> `rw_semaphore`. If that's the case, should we change the order to unlock 
>>> and free?
>>
>> No it doesn't free the rw_semaphore, that is in 'struct maps', what is
>> being freed is just something protected by rw_semaphore,
>> maps->maps_by_name, so your patch is right and I'm applying it, thanks.
>
> BTW, you forgot to add:
>
> Fixes: a7c2b572e217 ("perf map_groups: Auto sort maps by name, if needed")
>
> Which I did, and next time please CC the perf tools reviewers, as noted
> in MAINTAINERS, the lines starting with R:.

Missed that. Thank you for reminding and correction.

Cheers
>
> - Arnaldo
>
> [acme@...co perf]$ grep -A21 "PERFORMANCE EVENTS SUBSYSTEM$" MAINTAINERS
> PERFORMANCE EVENTS SUBSYSTEM
> M: Peter Zijlstra <peterz@...radead.org>
> M: Ingo Molnar <mingo@...hat.com>
> M: Arnaldo Carvalho de Melo <acme@...nel.org>
> R: Mark Rutland <mark.rutland@....com>
> R: Alexander Shishkin <alexander.shishkin@...ux.intel.com>
> R: Jiri Olsa <jolsa@...hat.com>
> R: Namhyung Kim <namhyung@...nel.org>
> L: linux-kernel@...r.kernel.org
> T: git git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git perf/core
> S: Supported
> F: kernel/events/*
> F: include/linux/perf_event.h
> F: include/uapi/linux/perf_event.h
> F: arch/*/kernel/perf_event*.c
> F: arch/*/kernel/*/perf_event*.c
> F: arch/*/kernel/*/*/perf_event*.c
> F: arch/*/include/asm/perf_event.h
> F: arch/*/kernel/perf_callchain.c
> F: arch/*/events/*
> F: arch/*/events/*/*
> F: tools/perf/
> [acme@...co perf]$