linux-kernel - Re: [PATCH v3 02/15] dt-bindings: clock: Fix qcom,dispcc bindings for sdm845/sc7180

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 31 Jan 2020 10:38:46 -0600
From:   Rob Herring <robh@...nel.org>
To:     Douglas Anderson <dianders@...omium.org>
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Stephen Boyd <sboyd@...nel.org>,
        Jeffrey Hugo <jhugo@...eaurora.org>,
        Taniya Das <tdas@...eaurora.org>,
        Jeffrey Hugo <jeffrey.l.hugo@...il.com>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        Harigovindan P <harigovi@...eaurora.org>,
        devicetree@...r.kernel.org, Matthias Kaehlcke <mka@...omium.org>,
        Kalyan Thota <kalyan_t@...eaurora.org>,
        Mark Rutland <mark.rutland@....com>,
        linux-clk <linux-clk@...r.kernel.org>,
        "Kristian H. Kristensen" <hoegsberg@...omium.org>,
        Michael Turquette <mturquette@...libre.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 02/15] dt-bindings: clock: Fix qcom,dispcc bindings for sdm845/sc7180

On Thu, Jan 30, 2020 at 3:12 PM Douglas Anderson <dianders@...omium.org> wrote:
>
> The qcom,dispcc bindings had a few problems with them:
>
> 1. They didn't specify all the clocks that dispcc is a client of.
>    Specifically on sc7180 there are two clocks from the DSI PHY and
>    two from the DP PHY.  On sdm845 there are actually two DSI PHYs
>    (each of which has two clocks) and an extra clock from the gcc.
>    These all need to be specified.
>
> 2. The sdm845.dtsi has existed for quite some time without specifying
>    the clocks.  The Linux driver was relying on global names to match
>    things up.  While we should transition things, it should be noted
>    in the bindings.
>
> 3. The names used the bindings for "xo" and "gpll0" didn't match the
>    names that QC used for these clocks internally and this was causing
>    confusion / difficulty with their code generation tools.  Switched
>    to the internal names to simplify everyone's lives.  It's not quite
>    as clean in a purist sense but it should avoid headaches.  This
>    officially changes the binding, but that seems OK in this case.
>
> Also note that I updated the example.
>
> Fixes: 5d28e44ba630 ("dt-bindings: clock: Add YAML schemas for the QCOM DISPCC clock bindings")
> Signed-off-by: Douglas Anderson <dianders@...omium.org>
> ---
>
> Changes in v3:
> - Added include file to description.
> - Discovered / added new gcc input clock on sdm845.
> - Split sc7180 and sdm845 into two files.
> - Switched names to internal QC names rather than logical ones.
> - Updated commit description.
>
> Changes in v2:
> - Patch ("dt-bindings: clock: Fix qcom,dispcc...") new for v2.
>
>  .../bindings/clock/qcom,dispcc.yaml           | 67 -------------
>  .../bindings/clock/qcom,sc7180-dispcc.yaml    | 84 ++++++++++++++++
>  .../bindings/clock/qcom,sdm845-dispcc.yaml    | 99 +++++++++++++++++++
>  3 files changed, 183 insertions(+), 67 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/clock/qcom,dispcc.yaml
>  create mode 100644 Documentation/devicetree/bindings/clock/qcom,sc7180-dispcc.yaml
>  create mode 100644 Documentation/devicetree/bindings/clock/qcom,sdm845-dispcc.yaml

Other than the same $id problem,

Reviewed-by: Rob Herring <robh@...nel.org>