linux-kernel - Re: [PATCH v4 2/2] kasan: add test for invalid size in memmove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1580439225.11126.34.camel@mtksdccf07>
Date:   Fri, 31 Jan 2020 10:53:45 +0800
From:   Walter Wu <walter-zh.wu@...iatek.com>
To:     Andrew Morton <akpm@...ux-foundation.org>
CC:     Andrey Ryabinin <aryabinin@...tuozzo.com>,
        Dmitry Vyukov <dvyukov@...gle.com>,
        Alexander Potapenko <glider@...gle.com>,
        "Matthias Brugger" <matthias.bgg@...il.com>,
        "kasan-dev@...glegroups.com" <kasan-dev@...glegroups.com>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        wsd_upstream <wsd_upstream@...iatek.com>,
        "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>
Subject: Re: [PATCH v4 2/2] kasan: add test for invalid size in memmove

On Thu, 2020-01-30 at 18:16 -0800, Andrew Morton wrote:
> On Thu, 30 Jan 2020 11:43:58 +0800 Walter Wu <walter-zh.wu@...iatek.com> wrote:
> 
> > On Fri, 2019-11-22 at 06:21 +0800, Andrey Ryabinin wrote:
> > > 
> > > On 11/12/19 9:53 AM, Walter Wu wrote:
> > > > Test negative size in memmove in order to verify whether it correctly
> > > > get KASAN report.
> > > > 
> > > > Casting negative numbers to size_t would indeed turn up as a large
> > > > size_t, so it will have out-of-bounds bug and be detected by KASAN.
> > > > 
> > > > Signed-off-by: Walter Wu <walter-zh.wu@...iatek.com>
> > > > Reviewed-by: Dmitry Vyukov <dvyukov@...gle.com>
> > > 
> > > Reviewed-by: Andrey Ryabinin <aryabinin@...tuozzo.com>
> > 
> > Hi Andrey, Dmitry, Andrew,
> > 
> > Would you tell me why this patch-sets don't merge into linux-next tree?
> > We lost something?
> > 
> 
> In response to [1/2] Andrey said "So let's keep this code as this" and
> you said "I will send a new v5 patch tomorrow".  So we're awaiting a v5
> patchset?
> 

Hi Andrew,

The [1/2] patch discussion shows below. Thanks for Dimitry help to
explain it. So that v4 patchset got Andrey's signature. Because I see
Andrey said "But I see you point now. No objections to the patch in that
case."

@Andrey, if I have an incorrect understanding, please let me know. 
Thanks for your help.

https://lkml.org/lkml/2019/11/21/1019
https://lkml.org/lkml/2019/11/21/1020


Walter