linux-kernel - Re: [PATCH v4 5/6] console: Introduce ->exit() callback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200201010804.GB1352@jagdpanzerIV.localdomain>
Date:   Sat, 1 Feb 2020 10:08:04 +0900
From:   Sergey Senozhatsky <sergey.senozhatsky@...il.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>,
        Petr Mladek <pmladek@...e.com>,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 5/6] console: Introduce ->exit() callback

On (20/01/31 13:27), Andy Shevchenko wrote:
[..]
> > 
> > I would probably push it a bit further (I posted this snippet in another
> > thread). If console is not on the list then there is nothing for us to do
> > and sysfs notify is pointless.
> 
> I didn't see post in the other thread, but I suppose that this snipped is
> for patch 4 in the series, correct?

No worries! Yes, for v4.

[..]
> > -	if (!res && console->exit)
> > +	if (console->exit)
> 
> >  		console->exit(console);
> >  
> >  	return res;
> 
> ...then something like
> 
> 		return console->exit(console);
> 
> 	return 0;
> 
> ...or...
> 
> 		res = console->exit(console);
> 
> Which one is preferable?

I don't really have preferences here, so up to you guys.

	-ss