lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 1 Feb 2020 16:28:45 +0900 From: Masami Hiramatsu <mhiramat@...nel.org> To: Tom Zanussi <zanussi@...nel.org> Cc: rostedt@...dmis.org, artem.bityutskiy@...ux.intel.com, mhiramat@...nel.org, linux-kernel@...r.kernel.org, linux-rt-users@...r.kernel.org Subject: Re: [PATCH 3/4] tracing: Remove useless code in dynevent_arg_pair_add() On Fri, 31 Jan 2020 15:55:33 -0600 Tom Zanussi <zanussi@...nel.org> wrote: > The final addition to q is unnecessary, since q isn't ever used > afterwards. > Yeah, thanks for updating :) Reviewed-by: Masami Hiramatsu <mhiramat@...nel.org> Thank you, > Signed-off-by: Tom Zanussi <zanussi@...nel.org> > --- > kernel/trace/trace_dynevent.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/trace/trace_dynevent.c b/kernel/trace/trace_dynevent.c > index f9cfcdc9d1f3..204275ec8d71 100644 > --- a/kernel/trace/trace_dynevent.c > +++ b/kernel/trace/trace_dynevent.c > @@ -322,7 +322,7 @@ int dynevent_arg_pair_add(struct dynevent_cmd *cmd, > pr_err("field string is too long: %s\n", arg_pair->rhs); > return -E2BIG; > } > - cmd->remaining -= delta; q += delta; > + cmd->remaining -= delta; > > return ret; > } > -- > 2.14.1 > -- Masami Hiramatsu <mhiramat@...nel.org>
Powered by blists - more mailing lists