linux-kernel - RE: [PATCH 1/3] dt-bindings: add device tree binding for Arm CryptoCell trng engine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 2 Feb 2020 13:04:20 +0000
From:   Hadar Gat <Hadar.Gat@....com>
To:     Rob Herring <robh@...nel.org>
CC:     Matt Mackall <mpm@...enic.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>,
        Jonathan Cameron <Jonathan.Cameron@...wei.com>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Gilad Ben-Yossef <gilad@...yossef.com>,
        Ofir Drang <Ofir.Drang@....com>
Subject: RE: [PATCH 1/3] dt-bindings: add device tree binding for Arm
 CryptoCell trng engine

Rob,
Thank you for noticing and notifying.
I will fix this and re-submit.
Hadar

-----Original Message-----
From: Rob Herring <robh@...nel.org>
Sent: Monday, 27 January 2020 16:28
To: Hadar Gat <Hadar.Gat@....com>
Cc: Matt Mackall <mpm@...enic.com>; Herbert Xu <herbert@...dor.apana.org.au>; David S. Miller <davem@...emloft.net>; Jonathan Cameron <Jonathan.Cameron@...wei.com>; linux-crypto@...r.kernel.org; devicetree@...r.kernel.org; linux-kernel@...r.kernel.org; Gilad Ben-Yossef <gilad@...yossef.com>; Ofir Drang <Ofir.Drang@....com>; Hadar Gat <Hadar.Gat@....com>
Subject: Re: [PATCH 1/3] dt-bindings: add device tree binding for Arm CryptoCell trng engine

On Mon, 27 Jan 2020 11:28:22 +0200, Hadar Gat wrote:
> The Arm CryptoCell is a hardware security engine. This patch adds DT
> bindings for its TRNG (True Random Number Generator) engine.
>
> Signed-off-by: Hadar Gat <hadar.gat@....com>
> ---
>  .../devicetree/bindings/rng/arm-cctrng.yaml        | 49 ++++++++++++++++++++++
>  1 file changed, 49 insertions(+)
>  create mode 100644
> Documentation/devicetree/bindings/rng/arm-cctrng.yaml
>

My bot found errors running 'make dt_binding_check' on your patch:

warning: no schema found in file: Documentation/devicetree/bindings/rng/arm-cctrng.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/rng/arm-cctrng.yaml: ignoring, error parsing file
Documentation/devicetree/bindings/display/simple-framebuffer.example.dts:21.16-37.11: Warning (chosen_node_is_root): /example-0/chosen: chosen node must be at root node
Documentation/devicetree/bindings/rng/arm-cctrng.yaml:  while parsing a block mapping
  in "<unicode string>", line 42, column 3 did not find expected key
  in "<unicode string>", line 47, column 3
Documentation/devicetree/bindings/Makefile:12: recipe for target 'Documentation/devicetree/bindings/rng/arm-cctrng.example.dts' failed
make[1]: *** [Documentation/devicetree/bindings/rng/arm-cctrng.example.dts] Error 1
Makefile:1263: recipe for target 'dt_binding_check' failed
make: *** [dt_binding_check] Error 2

See https://patchwork.ozlabs.org/patch/1229638
Please check and re-submit.
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.