linux-kernel - Re: [PATCH 1/2] clk: ls1028a: Fix warning on clamp() usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 03 Feb 2020 10:33:52 -0800
From:   Stephen Boyd <sboyd@...nel.org>
To:     Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>
Cc:     linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Wen He <wen.he_1@....com>
Subject: Re: [PATCH 1/2] clk: ls1028a: Fix warning on clamp() usage

Quoting Stephen Boyd (2020-02-02 21:25:06)
> These constants are used in clamp() with the value being clamped an
> unsigned long. Make them unsigned long defines so that clamp() doesn't
> complain about comparing different types.
> 
> In file included from include/linux/list.h:9,
>                  from include/linux/kobject.h:19,
>                  from include/linux/of.h:17,
>                  from include/linux/clk-provider.h:9,
>                  from drivers/clk/clk-plldig.c:8:
> drivers/clk/clk-plldig.c: In function 'plldig_determine_rate':
> include/linux/kernel.h:835:29: warning: comparison of distinct pointer types lacks a cast
>   835 |   (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
>       |
> 
> Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
> Cc: Wen He <wen.he_1@....com>
> Fixes: d37010a3c162 ("clk: ls1028a: Add clock driver for Display output interface")
> Signed-off-by: Stephen Boyd <sboyd@...nel.org>
> ---

Applied to clk-next