linux-kernel - Re: [PATCH v4 7/7] drivers: thermal: tsens: Remove unnecessary irq flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 3 Feb 2020 10:44:08 -0800
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     Amit Kucheria <amit.kucheria@...aro.org>
Cc:     linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        swboyd@...omium.org, sivaa@...eaurora.org,
        Andy Gross <agross@...nel.org>,
        Amit Kucheria <amit.kucheria@...durent.com>,
        linux-pm@...r.kernel.org
Subject: Re: [PATCH v4 7/7] drivers: thermal: tsens: Remove unnecessary irq
 flag

On Thu 30 Jan 05:27 PST 2020, Amit Kucheria wrote:

> IRQF_TRIGGER_HIGH is already specified through devicetree interrupts
> property. Remove it from code.
> 

Reviewed-by: Bjorn Andersson <bjorn.andersson@...aro.org>

> Signed-off-by: Amit Kucheria <amit.kucheria@...aro.org>
> ---
>  drivers/thermal/qcom/tsens.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/thermal/qcom/tsens.c b/drivers/thermal/qcom/tsens.c
> index 5b003d598234..9ee00c67144c 100644
> --- a/drivers/thermal/qcom/tsens.c
> +++ b/drivers/thermal/qcom/tsens.c
> @@ -118,7 +118,7 @@ static int tsens_register(struct tsens_priv *priv)
>  
>  	ret = devm_request_threaded_irq(&pdev->dev, irq,
>  					NULL, tsens_irq_thread,
> -					IRQF_TRIGGER_HIGH | IRQF_ONESHOT,
> +					IRQF_ONESHOT,
>  					dev_name(&pdev->dev), priv);
>  	if (ret) {
>  		dev_err(&pdev->dev, "%s: failed to get irq\n", __func__);
> -- 
> 2.20.1
>