[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <475ab05c-300b-fdbe-5de0-6fce8d1a360d@linuxfoundation.org>
Date: Mon, 3 Feb 2020 11:55:22 -0700
From: Shuah Khan <skhan@...uxfoundation.org>
To: Mimi Zohar <zohar@...ux.ibm.com>, Joe Perches <joe@...ches.com>,
jmorris@...ei.org, serge@...lyn.com, mpe@...erman.id.au,
erichte@...ux.ibm.com, nayna@...ux.ibm.com, yuehaibing@...wei.com
Cc: linux-security-module@...r.kernel.org,
linux-kernel@...r.kernel.org,
Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] security/integrity: Include __func__ in messages for
easier debug
On 2/3/20 6:21 AM, Mimi Zohar wrote:
> On Wed, 2020-01-29 at 19:08 -0800, Joe Perches wrote:
>> On Wed, 2020-01-29 at 19:01 -0700, Shuah Khan wrote:
>>> Change messages to messages to make it easier to debug. The following
>>> error message isn't informative enough to figure out what failed.
>>> Change messages to include function information.
>>>
>>> Signed-off-by: Shuah Khan <skhan@...uxfoundation.org>
>>> ---
>>> .../integrity/platform_certs/load_powerpc.c | 14 ++++++++------
>>> security/integrity/platform_certs/load_uefi.c | 17 ++++++++++-------
>>> 2 files changed, 18 insertions(+), 13 deletions(-)
>>>
>>> diff --git a/security/integrity/platform_certs/load_powerpc.c b/security/integrity/platform_certs/load_powerpc.c
>>
>> perhaps instead add #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
>> so all the pr_<level> logging is more specific.
>>
>> This would prefix all pr_<level> output with "integrity: "
>
Joe! Sorry for the delay in getting back to you.
> Agreed. Joe, could you post a patch with a proper patch description
> for this?
>
I have been looking into this a bit more and there is an opportunity
here to add #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt to integrity.h
and get rid of duplicate defines.
thanks,
-- Shuah
Powered by blists - more mailing lists