linux-kernel - Re: [PATCH] platform/x86: pmc_atom: Add Lex 2I385SW to critclk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <466fff4c-eb61-7fd5-1442-54499c3db645@redhat.com>
Date:   Mon, 3 Feb 2020 22:17:53 +0100
From:   Hans de Goede <hdegoede@...hat.com>
To:     Georg Müller <georgmueller@....net>,
        linux-kernel@...r.kernel.org, platform-driver-x86@...r.kernel.org,
        Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>
Subject: Re: [PATCH] platform/x86: pmc_atom: Add Lex 2I385SW to
 critclk_systems DMI table

Hi,

On 03-02-2020 21:11, Georg Müller wrote:
> The Lex 2I385SW board has two Intel I211 ethernet controllers. Without
> this patch, only the first port is usable. The second port fails to
> start with the following message:
> 
>      igb: probe of 0000:02:00.0 failed with error -2
> 
> Fixes: 648e921888ad ("clk: x86: Stop marking clocks as CLK_IS_CRITICAL")
> Tested-by: Georg Müller <georgmueller@....net>
> Signed-off-by: Georg Müller <georgmueller@....net>

Patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@...hat.com>

Regards,

Hans



> ---
>   drivers/platform/x86/pmc_atom.c | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/platform/x86/pmc_atom.c b/drivers/platform/x86/pmc_atom.c
> index 3e3c66dfec2e..ca684ed760d1 100644
> --- a/drivers/platform/x86/pmc_atom.c
> +++ b/drivers/platform/x86/pmc_atom.c
> @@ -383,6 +383,14 @@ static const struct dmi_system_id critclk_systems[] = {
>   			DMI_MATCH(DMI_PRODUCT_NAME, "3I380D"),
>   		},
>   	},
> +	{
> +		/* pmc_plt_clk* - are used for ethernet controllers */
> +		.ident = "Lex 2I385SW",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "Lex BayTrail"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "2I385SW"),
> +		},
> +	},
>   	{
>   		/* pmc_plt_clk* - are used for ethernet controllers */
>   		.ident = "Beckhoff CB3163",
> --
> 2.24.1
>