linux-kernel - Re: [PATCH v2 2/2] dt-bindings: net: bluetooth: Add device tree bindings for QTI chip WCN3991

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 03 Feb 2020 13:53:05 +0530
From:   gubbaven@...eaurora.org
To:     Matthias Kaehlcke <mka@...omium.org>
Cc:     marcel@...tmann.org, johan.hedberg@...il.com,
        linux-kernel@...r.kernel.org, linux-bluetooth@...r.kernel.org,
        robh@...nel.org, hemantg@...eaurora.org,
        linux-arm-msm@...r.kernel.org, bgodavar@...eaurora.org,
        tientzu@...omium.org, seanpaul@...omium.org, rjliao@...eaurora.org,
        yshavit@...gle.com, Rob Herring <robh+dt@...nel.org>,
        Frank Rowand <frowand.list@...il.com>,
        devicetree@...r.kernel.org
Subject: Re: [PATCH v2 2/2] dt-bindings: net: bluetooth: Add device tree
 bindings for QTI chip WCN3991

Hi Matthias,

On 2020-02-01 04:06, Matthias Kaehlcke wrote:
> + DT folks
> 
> On Fri, Jan 31, 2020 at 01:08:55PM +0530, Venkata Lakshmi Narayana 
> Gubba wrote:
>> Add compatible string for the Qualcomm WCN3991 Bluetooth controller
>> 
>> Signed-off-by: Venkata Lakshmi Narayana Gubba 
>> <gubbaven@...eaurora.org>
>> ---
>>  Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt | 3 +++
>>  1 file changed, 3 insertions(+)
>> 
>> diff --git 
>> a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt 
>> b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
>> index 68b67d9..e72045d 100644
>> --- a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
>> +++ b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
>> @@ -11,6 +11,7 @@ Required properties:
>>   - compatible: should contain one of the following:
>>     * "qcom,qca6174-bt"
>>     * "qcom,wcn3990-bt"
>> +   * "qcom,wcn3991-bt"
>>     * "qcom,wcn3998-bt"
>> 
>>  Optional properties for compatible string qcom,qca6174-bt:
>> @@ -30,6 +31,7 @@ Optional properties for compatible string 
>> qcom,wcn399x-bt:
>> 
>>   - max-speed: see 
>> Documentation/devicetree/bindings/serial/slave-device.txt
>>   - firmware-name: specify the name of nvm firmware to load
>> + - clocks: clock provided to the controller
>> 
>>  Examples:
>> 
>> @@ -56,5 +58,6 @@ serial@...000 {
>>  		vddch0-supply = <&vreg_l25a_3p3>;
>>  		max-speed = <3200000>;
>>  		firmware-name = "crnv21.bin";
>> +		clocks = <&rpmhcc>;
> 
> That specifies a clock controller, not a clock.
> 
> For a device with the SC7180 SoC we use this:
> 
> 		clocks = <&rpmhcc RPMH_RF_CLK2>;

[Venkata] :

Sure, we will update in next patch set.
> 
>>  	};
>>  };

Regards,
Venkata.