linux-kernel - Re: [PATCH] firmware: ti_sci: Correct the timeout type in ti_sci_do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a63c23ec-d468-fc9b-3990-becd7c120df6@ti.com>
Date:   Mon, 3 Feb 2020 10:38:43 +0200
From:   Tero Kristo <t-kristo@...com>
To:     Peter Ujfalusi <peter.ujfalusi@...com>, <nm@...com>,
        <ssantosh@...nel.org>, <santosh.shilimkar@...cle.com>
CC:     <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <lokeshvutla@...com>
Subject: Re: [PATCH] firmware: ti_sci: Correct the timeout type in
 ti_sci_do_xfer()

On 22/01/2020 12:40, Peter Ujfalusi wrote:
> msecs_to_jiffies() returns 'unsigned long' and the timeout parameter for
> wait_for_completion_timeout() is also 'unsigned long'
> 
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@...com>

Reviewed-by: Tero Kristo <t-kristo@...com>

> ---
>   drivers/firmware/ti_sci.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/firmware/ti_sci.c b/drivers/firmware/ti_sci.c
> index 3d8241cb6921..361a82817c1f 100644
> --- a/drivers/firmware/ti_sci.c
> +++ b/drivers/firmware/ti_sci.c
> @@ -422,7 +422,7 @@ static inline int ti_sci_do_xfer(struct ti_sci_info *info,
>   				 struct ti_sci_xfer *xfer)
>   {
>   	int ret;
> -	int timeout;
> +	unsigned long timeout;
>   	struct device *dev = info->dev;
>   
>   	ret = mbox_send_message(info->chan_tx, &xfer->tx_message);
> 

--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki