linux-kernel - RE: [PATCH v1 5/7] device property: Introduce fwnode_phy_is_fixed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM0PR04MB5636A3081D857484A970970493000@AM0PR04MB5636.eurprd04.prod.outlook.com>
Date:   Mon, 3 Feb 2020 09:21:02 +0000
From:   "Calvin Johnson (OSS)" <calvin.johnson@....nxp.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
CC:     "linux.cj@...il.com" <linux.cj@...il.com>,
        Jon Nettleton <jon@...id-run.com>,
        Russell King - ARM Linux <linux@...linux.org.uk>,
        Makarand Pawagi <makarand.pawagi@....com>,
        Cristi Sovaiala <cristian.sovaiala@....com>,
        Laurentiu Tudor <laurentiu.tudor@....com>,
        Ioana Ciornei <ioana.ciornei@....com>,
        Varun Sethi <V.Sethi@....com>,
        Pankaj Bansal <pankaj.bansal@....com>,
        "Rajesh V. Bikkina" <rajesh.bikkina@....com>,
        "Calvin Johnson (OSS)" <calvin.johnson@....nxp.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v1 5/7] device property: Introduce
 fwnode_phy_is_fixed_link()



> -----Original Message-----
> From: Andy Shevchenko <andy.shevchenko@...il.com>
> Subject: Re: [PATCH v1 5/7] device property: Introduce
> fwnode_phy_is_fixed_link()
> 
> On Fri, Jan 31, 2020 at 5:38 PM Calvin Johnson <calvin.johnson@....com>
> wrote:
> >
> > From: Calvin Johnson <calvin.johnson@....nxp.com>
> >
> > Introduce fwnode_phy_is_fixed_link() function that an Ethernet driver
> > can call on its PHY phandle to find out whether it's a fixed link PHY
> > or not.
> 
> > +/*
> > + * fwnode_phy_is_fixed_link()
> > + */
> 
> Please, do a full kernel doc description.

Sure will take care in v2.


> > +bool fwnode_phy_is_fixed_link(struct fwnode_handle *fwnode) {
> > +       struct fwnode_handle *fixed_node;
> > +       int len, err;
> > +       const char *managed;
> > +
> > +       fixed_node = fwnode_get_named_child_node(fwnode, "fixed-link");
> > +       if (fixed_node)
> > +               return fixed_node;
> > +
> > +       err = fwnode_property_read_string(fixed_node, "managed",
> > + &managed);
> 
> > +       if (err == 0 && strcmp(managed, "auto") != 0)
> > +               return true;
> > +
> > +       return false;
> 
> Maybe other way around?
> 
>   if (err)
>     return false;
> 
>   return !strcmp(managed, "auto");
> 
> ?
> 
> Same pattern perhaps for the patch where you introduce
> fwnode_get_phy_mode().

Thanks! Will take care in v2.

Regards
Calvin