lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 3 Feb 2020 12:00:43 +0200 From: Andy Shevchenko <andriy.shevchenko@...el.com> To: Thomas Weißschuh <linux@...ssschuh.net> Cc: Henrique de Moraes Holschuh <ibm-acpi@....eng.br>, Darren Hart <dvhart@...radead.org>, Andy Shevchenko <andy@...radead.org>, ibm-acpi-devel@...ts.sourceforge.net, platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v2 1/3] platform/x86: thinkpad_acpi: remove unused defines On Fri, Jan 31, 2020 at 03:36:48PM +0100, Thomas Weißschuh wrote: > They were never used. Thanks for the series. Unfortunately I may not proceed it since it misses our patchwork [1] for some reason. Besides that, this patch is okay, but the rest two must be: - unified together to avoid regression in the middle - done other way around, simple add aliases to *old* ones Don't forget to update any documentation if needed. [1]: https://patchwork.kernel.org/project/platform-driver-x86/list/ > > Signed-off-by: Thomas Weißschuh <linux@...ssschuh.net> > --- > drivers/platform/x86/thinkpad_acpi.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c > index da794dcfdd92..2d3a99e3efb7 100644 > --- a/drivers/platform/x86/thinkpad_acpi.c > +++ b/drivers/platform/x86/thinkpad_acpi.c > @@ -9323,9 +9323,6 @@ static struct ibm_struct mute_led_driver_data = { > #define GET_STOP "BCSG" > #define SET_STOP "BCSS" > > -#define START_ATTR "charge_start_threshold" > -#define STOP_ATTR "charge_stop_threshold" > - > enum { > BAT_ANY = 0, > BAT_PRIMARY = 1, -- With Best Regards, Andy Shevchenko
Powered by blists - more mailing lists