[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200203110545.GB24291@pengutronix.de>
Date: Mon, 3 Feb 2020 12:05:45 +0100
From: Marco Felsch <m.felsch@...gutronix.de>
To: Martin Kepplinger <martin.kepplinger@...i.sm>
Cc: robh@...nel.org, mark.rutland@....com, shawnguo@...nel.org,
devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
kernel@...gutronix.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: librem5-devkit: add lsm9ds1 mount matrix
Hi Martin,
On 20-01-20 11:07, Martin Kepplinger wrote:
> The IMU chip on the librem5-devkit is not mounted at the "natural" place
> that would match normal phone orientation (see the documentation for the
> details about what that is).
>
> Since the lsm9ds1 driver supports providing a mount matrix, we can describe
> the orientation on the board in the dts:
I didn't found the patch which adds the iio_read_mount_matrix()
support. Appart of that your patch looks good so feel free to add my:
Reviewed-by: Marco Felsch <m.felsch@...gutronix.de>
Regards,
Marco
> Create a right-handed coordinate system (x * -1; see the datasheet for the
> axis) and rotate 180 degrees around the y axis because the device sits on
> the back side from the display.
>
> Signed-off-by: Martin Kepplinger <martin.kepplinger@...i.sm>
> ---
>
> tested on the librem5-devkit of course, finally fixing the orientation problem
> for the accelerometer :)
>
> thanks,
>
> martin
>
>
> arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> index 703254282b96..6c8ab009081b 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> @@ -457,6 +457,9 @@
> reg = <0x6a>;
> vdd-supply = <®_3v3_p>;
> vddio-supply = <®_3v3_p>;
> + mount-matrix = "1", "0", "0",
> + "0", "1", "0",
> + "0", "0", "-1";
> };
> };
>
> --
> 2.20.1
Powered by blists - more mailing lists