linux-kernel - RE: Confused about hlist_unhashed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <154c51cc385544789c9fa0b233fc76e7@AcuMS.aculab.com>
Date:   Mon, 3 Feb 2020 16:05:25 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'Marco Elver' <elver@...gle.com>
CC:     Eric Dumazet <edumazet@...gle.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Will Deacon <will@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        "Paul E. McKenney" <paulmck@...nel.org>,
        the arch/x86 maintainers <x86@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: RE: Confused about hlist_unhashed_lockless()

From: Marco Elver
> Sent: 03 February 2020 15:55
> 
> On Mon, 3 Feb 2020 at 16:45, David Laight <David.Laight@...lab.com> wrote:
> >
> > From: Eric Dumazet
> > > Sent: 31 January 2020 18:53
> > >
> > > On Fri, Jan 31, 2020 at 10:48 AM Eric Dumazet <edumazet@...gle.com> wrote:
> > > >
> > >
> > > > This is nice, now with have data_race()
> > > >
> > > > Remember these patches were sent 2 months ago, at a time we were
> > > > trying to sort out things.
> > > >
> > > > data_race() was merged a few days ago.
> > >
> > > Well, actually data_race() is not there yet anyway.
> >
> > Shouldn't it be NO_DATA_RACE() ??
> 
> Various options were considered, and based on feedback from Linus,
> decided 'data_race(..)' is the best option:
>   https://lore.kernel.org/linux-fsdevel/CAHk-
> =wg5CkOEF8DTez1Qu0XTEFw_oHhxN98bDnFqbY7HL5AB2g@...l.gmail.com/
> 
> It's meant to be as unobtrusive as possible, and an all-caps macro was
> ruled out.

Except that it then looks like something that actually does something.

> Second, the "NO_" prefix would be incorrect, since it'd be the
> opposite of what it is. The macro is meant to document and mark a
> deliberate data race.

It should be IGNORE_DATA_RACE() then.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)