linux-kernel - Re: [PATCH] fuse: Allow parallel DIO reads and check NOWAIT case for DIO writes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200203040051.GB11846@cqw-OptiPlex-7050>
Date:   Mon, 3 Feb 2020 12:00:51 +0800
From:   chenqiwu <qiwuchen55@...il.com>
To:     Bernd Schubert <bernd.schubert@...tmail.fm>
Cc:     miklos@...redi.hu, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org, chenqiwu <chenqiwu@...omi.com>
Subject: Re: [PATCH] fuse: Allow parallel DIO reads and check NOWAIT case for
 DIO writes

On Sun, Feb 02, 2020 at 10:25:43PM +0100, Bernd Schubert wrote:
> 
> 
> > @@ -1518,6 +1525,9 @@ static ssize_t fuse_direct_read_iter(struct kiocb *iocb, struct iov_iter *to)
> >  
> >  		res = __fuse_direct_read(&io, to, &iocb->ki_pos);
> >  	}
> > +	inode_unlock_shared(inode);
> > +
> > +	file_accessed(iocb->ki_filp);
> 
> 
> Shouldn't the file_accessed() in different patch, with a description? It
> looks totally unrelated to locking?
>
Thanks for your remind! file_accessed() is used to update atime for
every direct read, it's totally unrelated to locking. I will separate
it to another patch.