linux-kernel - Re: [PATCH -next] watchdog: fix mtk_wdt.c RESET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200203174937.GA18628@roeck-us.net>
Date:   Mon, 3 Feb 2020 09:49:37 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        "linux-watchdog@...r.kernel.org" <linux-watchdog@...r.kernel.org>,
        "wim@...ux-watchdog.org" <wim@...ux-watchdog.org>,
        Matthias Brugger <matthias.bgg@...il.com>
Subject: Re: [PATCH -next] watchdog: fix mtk_wdt.c RESET_CONTROLLER build
 error

On Mon, Feb 03, 2020 at 08:10:29AM -0800, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@...radead.org>
> 
> Fix build error when CONFIG_RESET_CONTROLLER is not set by
> selecting RESET_CONTROLLER.
> 
> ld: drivers/watchdog/mtk_wdt.o: in function `mtk_wdt_probe':
> mtk_wdt.c:(.text+0x3ec): undefined reference to `devm_reset_controller_register'
> 
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Wim Van Sebroeck <wim@...ux-watchdog.org>
> Cc: Guenter Roeck <linux@...ck-us.net>
> Cc: Matthias Brugger <matthias.bgg@...il.com>
> Cc: linux-watchdog@...r.kernel.org

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>  drivers/watchdog/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- linux-next-20200203.orig/drivers/watchdog/Kconfig
> +++ linux-next-20200203/drivers/watchdog/Kconfig
> @@ -841,6 +841,7 @@ config MEDIATEK_WATCHDOG
>  	tristate "Mediatek SoCs watchdog support"
>  	depends on ARCH_MEDIATEK || COMPILE_TEST
>  	select WATCHDOG_CORE
> +	select RESET_CONTROLLER
>  	help
>  	  Say Y here to include support for the watchdog timer
>  	  in Mediatek SoCs.
> 
>