lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 03 Feb 2020 16:41:35 -0800 From: Stephen Boyd <swboyd@...omium.org> To: Matthias Kaehlcke <mka@...omium.org>, Sandeep Maheswaram <sanm@...eaurora.org> Cc: Andy Gross <agross@...nel.org>, Bjorn Andersson <bjorn.andersson@...aro.org>, Kishon Vijay Abraham I <kishon@...com>, Rob Herring <robh+dt@...nel.org>, Mark Rutland <mark.rutland@....com>, Doug Anderson <dianders@...omium.org>, linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org, devicetree@...r.kernel.org Subject: Re: [PATCH v4 4/8] dt-bindings: phy: qcom-qusb2: Add support for overriding Phy tuning parameters Quoting Matthias Kaehlcke (2020-01-29 12:38:19) > On Wed, Jan 29, 2020 at 07:21:55PM +0530, Sandeep Maheswaram wrote: > > Add support for overriding QUSB2 V2 phy tuning parameters > > in device tree bindings. > > > > Signed-off-by: Sandeep Maheswaram <sanm@...eaurora.org> > > Reviewed-by: Rob Herring <robh@...nel.org> > > --- > > .../devicetree/bindings/phy/qcom,qusb2-phy.yaml | 33 ++++++++++++++++++++++ > > 1 file changed, 33 insertions(+) Reviewed-by: Stephen Boyd <swboyd@...omium.org> > > > > diff --git a/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml > > index 43082c8..dfef356 100644 > > --- a/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml > > +++ b/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml > > @@ -80,6 +80,28 @@ properties: > > maximum: 63 > > default: 0 > > > > + qcom,bias-ctrl-value: > > + description: > > + It is a 6 bit value that specifies bias-ctrl-value. It is a PHY > > + tuning parameter that may vary for different boards of same SOC. > > + This property is applicable to only QUSB2 v2 PHY. > > As commented on 'dt-bindings: phy: qcom,qusb2: Convert QUSB2 phy bindings > to yaml' a possible improvement could be to restrict these properties to > the QUSB2 v2 PHY through the schema. Can this be done? It's nice to keep constraints type, otherwise the yaml binding is not as useful.
Powered by blists - more mailing lists