linux-kernel - Re: [PATCH] ASoC: wcd934x: Remove some unnecessary NULL checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 4 Feb 2020 10:00:39 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Nathan Chancellor <natechancellor@...il.com>
Cc:     Liam Girdwood <lgirdwood@...il.com>,
        Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
        clang-built-linux@...glegroups.com
Subject: Re: [PATCH] ASoC: wcd934x: Remove some unnecessary NULL checks

On Mon, Feb 03, 2020 at 11:01:44PM -0700, Nathan Chancellor wrote:
> Clang warns:
> 
> ../sound/soc/codecs/wcd934x.c:1886:11: warning: address of array
> 'wcd->rx_chs' will always evaluate to 'true' [-Wpointer-bool-conversion]
>         if (wcd->rx_chs) {
>         ~~  ~~~~~^~~~~~
> ../sound/soc/codecs/wcd934x.c:1894:11: warning: address of array
> 'wcd->tx_chs' will always evaluate to 'true' [-Wpointer-bool-conversion]
>         if (wcd->tx_chs) {
>         ~~  ~~~~~^~~~~~
> 2 warnings generated.
> 
> Arrays that are in the middle of a struct are never NULL so they don't
> need a check like this.

I'm not convincd this is a sensible warning, at the use site a
pointer to an array in a struct looks identical to an array
embedded in the struct so it's not such a bad idea to check and
refactoring of the struct could easily introduce problems.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)