[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20200204.124359.1467998825171045884.davem@davemloft.net>
Date: Tue, 04 Feb 2020 12:43:59 +0100 (CET)
From: David Miller <davem@...emloft.net>
To: harinik@...inx.com
Cc: nicolas.ferre@...rochip.com, claudiu.beznea@...rochip.com,
kuba@...nel.org, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org, michal.simek@...inx.com,
harini.katakam@...inx.com, harinikatakamlinux@...il.com
Subject: Re: [PATCH v2 1/2] net: macb: Remove unnecessary alignment check
for TSO
From: Harini Katakam <harinik@...inx.com>
Date: Tue, 4 Feb 2020 15:52:55 +0530
>> > will never trigger this IPPROTO_TCP condition after your change.
>
> Yes, this is dead code now. I'll remove it.
>
>> >
>> > A lot of things about this patch do not add up.
>
> Please let me know if you have any further concerns.
Looks good with the above correction and a rework of your commit message
to explain things more clearly.
Thank you.
Powered by blists - more mailing lists