linux-kernel - Re: [PATCH] HID: apple: Add support for recent firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <nycvar.YFH.7.76.2002041347250.26888@cbobk.fhfr.pm>
Date:   Tue, 4 Feb 2020 13:48:35 +0100 (CET)
From:   Jiri Kosina <jikos@...nel.org>
To:     Mansour Behabadi <mansour@...lot.com>
cc:     Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HID: apple: Add support for recent firmware

On Wed, 29 Jan 2020, Mansour Behabadi wrote:

> Magic Keyboards with more recent firmware (0x0100) report
> Fn key differently. Without this patch, Fn key may not
> behave as expected and may not be configurable via hid_apple
> fnmode module parameter.
> 
> Signed-off-by: Mansour Behabadi <mansour@...lot.com>
> ---
>  drivers/hid/hid-apple.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/hid-apple.c b/drivers/hid/hid-apple.c
> index 6ac8becc2372..d732d1d10caf 100644
> --- a/drivers/hid/hid-apple.c
> +++ b/drivers/hid/hid-apple.c
> @@ -340,7 +340,8 @@ static int apple_input_mapping(struct hid_device *hdev, struct hid_input *hi,
>  		unsigned long **bit, int *max)
>  {
>  	if (usage->hid == (HID_UP_CUSTOM | 0x0003) ||
> -			usage->hid == (HID_UP_MSVENDOR | 0x0003)) {
> +			usage->hid == (HID_UP_MSVENDOR | 0x0003) ||
> +			usage->hid == (HID_UP_HPVENDOR2 | 0x0003)) {
>  		/* The fn key on Apple USB keyboards */

Hmm, one day we should probably ditch this "vendor-specific" naming, which 
doesn't really match reality at all any more.

Also the mappings in hid-input for these usage pages are pretty awkward 
these days.

Anyway, that is for later. I am queuing your patch now, thanks.

-- 
Jiri Kosina
SUSE Labs