[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAHp75Ve2_cH7M4nLQ-KynPWRt6NvCGk3LGafOEAjigfNyprcZw@mail.gmail.com>
Date: Tue, 4 Feb 2020 16:39:45 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Thomas Bogendoerfer <tbogendoerfer@...e.de>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Jiri Slaby <jslaby@...e.com>,
Paul Burton <paulburton@...nel.org>,
"open list:SERIAL DRIVERS" <linux-serial@...r.kernel.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] serial: 8250_ioc3: Fix ioremap call
On Tue, Feb 4, 2020 at 1:40 PM Thomas Bogendoerfer
<tbogendoerfer@...e.de> wrote:
>
> Commit 4bdc0d676a64 ("remove ioremap_nocache and devm_ioremap_nocache")
> removed devm_ioremap_nocache, but 8250_ioc3 wasn't upstream at that
> time. So fix 8250_ioc3 by using devm_ioremap.
>
Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>
> Fixes: 0ce5ebd24d25 ("mfd: ioc3: Add driver for SGI IOC3 chip")
Basically it happened due to ioremap_nocache() removal, but it really
doesn't matter because in this case no functional change is expected.
> Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@...e.de>
> ---
> drivers/tty/serial/8250/8250_ioc3.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/8250/8250_ioc3.c b/drivers/tty/serial/8250/8250_ioc3.c
> index 4c405f1b9c67..d5a39e105a76 100644
> --- a/drivers/tty/serial/8250/8250_ioc3.c
> +++ b/drivers/tty/serial/8250/8250_ioc3.c
> @@ -47,7 +47,7 @@ static int serial8250_ioc3_probe(struct platform_device *pdev)
> if (!data)
> return -ENOMEM;
>
> - membase = devm_ioremap_nocache(&pdev->dev, r->start, resource_size(r));
> + membase = devm_ioremap(&pdev->dev, r->start, resource_size(r));
> if (!membase)
> return -ENOMEM;
>
> --
> 2.24.1
>
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists