linux-kernel - Re: [PATCH 2/3] Documentation: watchdog: qcom-wdt: Remove deprecated compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200204160958.GB17320@roeck-us.net>
Date:   Tue, 4 Feb 2020 08:09:58 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Ansuel Smith <ansuelsmth@...il.com>
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Wim Van Sebroeck <wim@...ux-watchdog.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        linux-arm-msm@...r.kernel.org, linux-watchdog@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] Documentation: watchdog: qcom-wdt: Remove deprecated
 compatible

On Tue, Feb 04, 2020 at 04:21:02PM +0100, Ansuel Smith wrote:
> "qcom,kpss-wdt-msm8960"
> "qcom,kpss-wdt-apq8064"
> "qcom,kpss-wdt-ipq8064"
> "qcom,kpss-wdt-ipq4019"
> 
> and deprectaed and not used in the driver code at all. Drop them and
> fix the example.
> 
Rob may correct me, but I don't think you can just remove
deprecated properties. It doesn't matter if the driver supports
it or not; after all, DT property descriptions are supposed
to be OS independent.

Guenter

> Signed-off-by: Ansuel Smith <ansuelsmth@...il.com>
> ---
>  Documentation/devicetree/bindings/watchdog/qcom-wdt.txt | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt b/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt
> index 41aeaa2ff0f8..33081bd33637 100644
> --- a/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt
> +++ b/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt
> @@ -4,10 +4,6 @@ Qualcomm Krait Processor Sub-system (KPSS) Watchdog
>  Required properties :
>  - compatible : shall contain only one of the following:
>  
> -			"qcom,kpss-wdt-msm8960"
> -			"qcom,kpss-wdt-apq8064"
> -			"qcom,kpss-wdt-ipq8064"
> -			"qcom,kpss-wdt-ipq4019"
>  			"qcom,kpss-timer"
>  			"qcom,scss-timer"
>  			"qcom,kpss-wdt"
> @@ -21,7 +17,7 @@ Optional properties :
>  
>  Example:
>  	watchdog@...a038 {
> -		compatible = "qcom,kpss-wdt-ipq8064";
> +		compatible = "qcom,kpss-timer";
>  		reg = <0x0208a038 0x40>;
>  		clocks = <&sleep_clk>;
>  		timeout-sec = <10>;
> -- 
> 2.24.0
>